chore: don't fail logout if cookie is not found #3871
Conversation
| if (c) { | ||
| cy.clearCookie(c.name) | ||
| } |
There was a problem hiding this comment.
The end goal is to remove the cookie. If it doesn't exist in the first place, this action should not fail, IMO.
There was a problem hiding this comment.
I am not sure I understand this, however it is fine by me to change the check as long as we have the assertion after login. Can you confirm that we assert the cookie after successful login?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
+ Coverage 77.99% 78.02% +0.02%
==========================================
Files 360 360
Lines 25198 25205 +7
==========================================
+ Hits 19654 19665 +11
+ Misses 4040 4035 -5
- Partials 1504 1505 +1 ☔ View full report in Codecov by Sentry. |
|
Replaced by #3935 |
This should deflake the CRDB tests, that sometimes fail on master. From what I can tell, the issue is that the cookie can be removed due to other means, which then results in repeated calls to
logoutfailing. Unfortunately, it's pretty difficult to debug, why the cookie is removed in the first place. I am also unsure, why this only happens on CRDB (pretty consistently on CI).Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments